Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9860 )
Change subject: IMPALA-6769: Avoid pulling incoherent Hadoop dependencies. ...................................................................... Patch Set 1: Code-Review+2 (2 comments) This makes sense to me. Hive LLAP should not impact our Java code. One question I have: Is there a way to unify/standardize the exclusions/inclusions? We have something separate for thrift. Do we want something similar for Parquet? It doesn't need to happen in this code change, but if there is a way to put them all in one place, that would be good. http://gerrit.cloudera.org:8080/#/c/9860/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9860/1//COMMIT_MSG@16 PS1, Line 16: sentsentry.hbase Nit: Is this supposed to be "sentry,hbase"? http://gerrit.cloudera.org:8080/#/c/9860/1/fe/pom.xml File fe/pom.xml: http://gerrit.cloudera.org:8080/#/c/9860/1/fe/pom.xml@720 PS1, Line 720: <groupId>org.apache.parquet</groupId> : <artifactId>parquet-hadoop-bundle</artifactId> : <version>${parquet.version}</version> Does it make sense to do something similar for the parquet dependency? -- To view, visit http://gerrit.cloudera.org:8080/9860 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie4b38c4fc5e30ec1464586282f08e3b82f30d7bd Gerrit-Change-Number: 9860 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Sun, 01 Apr 2018 01:28:54 +0000 Gerrit-HasComments: Yes
