Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9901 )

Change subject: IMPALA-6791: distcc server setup script
......................................................................


Patch Set 6:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/9901/6/bin/distcc/distcc_server_setup.sh
File bin/distcc/distcc_server_setup.sh:

http://gerrit.cloudera.org:8080/#/c/9901/6/bin/distcc/distcc_server_setup.sh@62
PS6, Line 62:  a
> nit: 6 and 7
Done


http://gerrit.cloudera.org:8080/#/c/9901/6/bin/distcc/distcc_server_setup.sh@81
PS6, Line 81: # Configure ccache for distccd user
> Do you think it's a good idea to turn these comments into echos? I saw that
Sure, seems fine either way to me.



--
To view, visit http://gerrit.cloudera.org:8080/9901
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a145911f095eb8e173694475cc2dac65eb7c7bb
Gerrit-Change-Number: 9901
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Philip Zeyliger <[email protected]>
Gerrit-Reviewer: Taras Bobrovytsky <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Comment-Date: Tue, 03 Apr 2018 23:29:28 +0000
Gerrit-HasComments: Yes

Reply via email to