Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9916 )
Change subject: IMPALA-6792: Fail status reporting if coordinator refuses connections ...................................................................... Patch Set 2: (1 comment) Just a thought passing by, no need to hold the change up for this. http://gerrit.cloudera.org:8080/#/c/9916/2/be/src/runtime/query-state.cc File be/src/runtime/query-state.cc: http://gerrit.cloudera.org:8080/#/c/9916/2/be/src/runtime/query-state.cc@274 PS2, Line 274: << "Query " << PrintId(query_id()) << " may hang. See IMPALA-2990."; Should we include the reason for the abort here? Otherwise the large number of cases that possibly lead to this error could make debugging unnecessarily hard. -- To view, visit http://gerrit.cloudera.org:8080/9916 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If668838f99f78b5ffa713488178b2eb5799ba220 Gerrit-Change-Number: 9916 Gerrit-PatchSet: 2 Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 04 Apr 2018 02:14:14 +0000 Gerrit-HasComments: Yes
