Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9909 )
Change subject: IMPALA-6801: Cleanup request_pool ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/9909/4/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/9909/4/be/src/service/impala-server.cc@1721 PS4, Line 1721: // For statement types other than QUERY/DML, show an empty string for resource pool > Just to check my understanding. Was this change made to preserve the existi Correct. I debated changing that user visible behavior (and updating the test instead) so we'd always print the pool for these stmts, but that seemed potentially confusing since they won't be queued by admission control. So printing no resource pool seems to make sense. -- To view, visit http://gerrit.cloudera.org:8080/9909 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3bee843ef7d72ba14d487fdb56e55fa3660aafd3 Gerrit-Change-Number: 9909 Gerrit-PatchSet: 4 Gerrit-Owner: Dan Hecht <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 04 Apr 2018 23:53:19 +0000 Gerrit-HasComments: Yes
