Dimitris Tsirogiannis has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9921 )

Change subject: IMPALA-6793: Fix empty metadata after statestore restarts
......................................................................


Patch Set 4:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/9921/4/be/src/catalog/catalog-server.cc
File be/src/catalog/catalog-server.cc:

http://gerrit.cloudera.org:8080/#/c/9921/4/be/src/catalog/catalog-server.cc@232
PS4, Line 232: update statestore
"topic update"


http://gerrit.cloudera.org:8080/#/c/9921/4/be/src/catalog/catalog-server.cc@234
PS4, Line 234:   if (delta.from_version == 0 && delta.to_version == 0 &&
> I just found that we can detect whether the statestore restarted using delt
Hm, can you elaborate a bit? Why isn't the from_version sufficient for 
detecting the restart? Essentially, how do  the values of from_version, 
to_version and last_sent_catalog_version_ change in the case of statestore 
restart?


http://gerrit.cloudera.org:8080/#/c/9921/4/be/src/catalog/catalog-server.cc@236
PS4, Line 236:     last_sent_catalog_version_ = 0L;
Mind adding a log entry here to mention that a non-delta request from the 
statestore was received?



--
To view, visit http://gerrit.cloudera.org:8080/9921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I332a60e172af84b93b3544373fe363cdced5e8d0
Gerrit-Change-Number: 9921
Gerrit-PatchSet: 4
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Apr 2018 23:06:32 +0000
Gerrit-HasComments: Yes

Reply via email to