Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9391 )
Change subject: IMPALA-5607: Add additional units to EXTRACT, DATE_PART, TRUNC ...................................................................... Patch Set 2: I pulled out the breaking parts into https://gerrit.cloudera.org/#/c/9957/. I don't think this is on track to make 3.0 but we could get the breaking parts in (which I don't think are especially controversial) then continue with the remaining parts of this review. -- To view, visit http://gerrit.cloudera.org:8080/9391 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If3df97d685af3e81a40ce8a4f277a5c543d3ea57 Gerrit-Change-Number: 9391 Gerrit-PatchSet: 2 Gerrit-Owner: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 09 Apr 2018 19:11:22 +0000 Gerrit-HasComments: No
