Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9957 )
Change subject: IMPALA-5607: part 1: breaking extract/date_part changes ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/9957/2/be/src/exprs/udf-builtins-ir.cc File be/src/exprs/udf-builtins-ir.cc: http://gerrit.cloudera.org:8080/#/c/9957/2/be/src/exprs/udf-builtins-ir.cc@117 PS2, Line 117: static int64_t ExtractMillisecond(const time_duration& time) { : // Fractional seconds are nanoseconds because Boost is configured : // to use nanoseconds precision : return time.fractional_seconds() / (NANOS_PER_MICRO * MICROS_PER_MILLI) : + time.seconds() * MILLIS_PER_SEC; : } > I don't see an obvious place. be/src/runtime/timestamp-value.h is the close How about util/time.h ? It seems to be a generic place for time related util functions. -- To view, visit http://gerrit.cloudera.org:8080/9957 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42d83712d9bb3a4900bec38a9c009dcf2a1fe019 Gerrit-Change-Number: 9957 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 09 Apr 2018 22:00:57 +0000 Gerrit-HasComments: Yes
