Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9949 )
Change subject: IMPALA-6822: Add a query option to control shuffling by distinct exprs ...................................................................... Patch Set 4: (2 comments) We have no end-to-end coverage with the option set to false. I think we need to expand test_aggregation.py to cover both variants. http://gerrit.cloudera.org:8080/#/c/9949/4/fe/src/test/java/org/apache/impala/planner/PlannerTest.java File fe/src/test/java/org/apache/impala/planner/PlannerTest.java: http://gerrit.cloudera.org:8080/#/c/9949/4/fe/src/test/java/org/apache/impala/planner/PlannerTest.java@79 PS4, Line 79: TQueryOptions options = defaultQueryOptions(); Let's run both variants in this .test file. You can use ---- a QUERYOPTIONS section to set the value of the query option for each QUERY. See runtime-filter-query-options.test for an example use http://gerrit.cloudera.org:8080/#/c/9949/4/testdata/workloads/functional-planner/queries/PlannerTest/no-shuffle-by-distinct.test File testdata/workloads/functional-planner/queries/PlannerTest/no-shuffle-by-distinct.test: http://gerrit.cloudera.org:8080/#/c/9949/4/testdata/workloads/functional-planner/queries/PlannerTest/no-shuffle-by-distinct.test@6 PS4, Line 6: |/home/twang/projects/impala/fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java:[892,58] clean -- To view, visit http://gerrit.cloudera.org:8080/9949 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icb4b4576fb29edd62cf4b4ba0719c0e0a2a5a8dc Gerrit-Change-Number: 9949 Gerrit-PatchSet: 4 Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Comment-Date: Mon, 09 Apr 2018 22:51:12 +0000 Gerrit-HasComments: Yes
