Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9976 )

Change subject: Move some test_spilling debug actions to exhaustive
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/9976/2/tests/query_test/test_spilling.py
File tests/query_test/test_spilling.py:

http://gerrit.cloudera.org:8080/#/c/9976/2/tests/query_test/test_spilling.py@38
PS2, Line 38:                    reason='Queries may not spill on larger 
clusters')
> Not related to current change: would setting memlimits make them spill?
We already set buffer_pool_limit to force all these queries to spill, the 
problem is that the amount of data per impalad changes. I expect it would work 
fine on a 3 node remote cluster, but that probably needs testing.


http://gerrit.cloudera.org:8080/#/c/9976/2/tests/query_test/test_spilling.py@51
PS2, Line 51:       debug_action_dims.extend(EXHAUSTIVE_DEBUG_ACTION_DIMS)
> nit: I think this mutates CORE_DEBUG_ACTION_DIMS, which isn't your intentio
Oops.



--
To view, visit http://gerrit.cloudera.org:8080/9976
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ea9f6c299480f8dfc943635342e4473499cc8ad
Gerrit-Change-Number: 9976
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 Apr 2018 16:21:18 +0000
Gerrit-HasComments: Yes

Reply via email to