Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9986 )
Change subject: IMPALA-3307: Add support for IANA time-zone db ...................................................................... Patch Set 1: (2 comments) Just skimmed through. Will do several further passes http://gerrit.cloudera.org:8080/#/c/9986/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9986/1//COMMIT_MSG@34 PS1, Line 34: --hdfs_zoneinfo_dir Why call it hdfs_zone_dir when it can also refer to S3 and ADLS? Maybe it could be just --zoneinfo_dir and the given URI would specify the storage. http://gerrit.cloudera.org:8080/#/c/9986/1//COMMIT_MSG@45 PS1, Line 45: --hdfs_zoneabbrev_config Same as above. -- To view, visit http://gerrit.cloudera.org:8080/9986 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I93c1fbffe81f067919706e30db0a34d0e58e7e77 Gerrit-Change-Number: 9986 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Jeges <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 11 Apr 2018 16:23:39 +0000 Gerrit-HasComments: Yes
