Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9964 )
Change subject: IMPALA-5814: Remove startup flag to disable admission control ...................................................................... Patch Set 2: Code-Review+2 (1 comment) This looks good. I don't think the change will be user-visible unless they have disabled admission control but provided admission control config files (since the default even with AC enabled is to not apply any limits). http://gerrit.cloudera.org:8080/#/c/9964/2/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: http://gerrit.cloudera.org:8080/#/c/9964/2/be/src/runtime/coordinator.cc@787 PS2, Line 787: DCHECK(admission_controller); nit: != nullptr -- To view, visit http://gerrit.cloudera.org:8080/9964 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9bf4087ce03ca63f82fd27c6d94b578881b85d42 Gerrit-Change-Number: 9964 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 11 Apr 2018 20:39:52 +0000 Gerrit-HasComments: Yes
