Joe McDonnell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9995 )

Change subject: IMPALA-6811: Increase timeout on S3 for test_exchange_delays
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/9995/1/tests/custom_cluster/test_exchange_delays.py
File tests/custom_cluster/test_exchange_delays.py:

http://gerrit.cloudera.org:8080/#/c/9995/1/tests/custom_cluster/test_exchange_delays.py@43
PS1, Line 43:       + " --datastream_sender_timeout_ms=5000")
> Are the semantics of this test and its comment still valid? With the increa
>From testing this, the semantics of this test aren't valid even without this 
>change. When the sender times out, that aborts the query. There is no 
>subsequent batch. The results don't exist.

I will file a JIRA. I think we should fix that separately.


http://gerrit.cloudera.org:8080/#/c/9995/2/tests/custom_cluster/test_exchange_delays.py
File tests/custom_cluster/test_exchange_delays.py:

http://gerrit.cloudera.org:8080/#/c/9995/2/tests/custom_cluster/test_exchange_delays.py@29
PS2, Line 29: IS_S3 or IS_ADLS
> These aren't being imported from what I can tell.
Done



--
To view, visit http://gerrit.cloudera.org:8080/9995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I967e6eb336c801219c77d657655c42984910b479
Gerrit-Change-Number: 9995
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Reviewer: Lars Volker <l...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 Apr 2018 21:35:29 +0000
Gerrit-HasComments: Yes

Reply via email to