Philip Zeyliger has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10026 )

Change subject: IMPALA-4631: loosen monotonic clock DCHECK
......................................................................


Patch Set 1: Code-Review+2

(2 comments)

Weird. +2 but see my s/e/eps/ suggestion.

http://gerrit.cloudera.org:8080/#/c/10026/1/be/src/runtime/fragment-instance-state.cc
File be/src/runtime/fragment-instance-state.cc:

http://gerrit.cloudera.org:8080/#/c/10026/1/be/src/runtime/fragment-instance-state.cc@323
PS1, Line 323:     // TODO: IMPALA-4631: Occasionally we see other_time = 
total_time + ε where ε is 1,
I'm worried that the epsilon will kill some editor or compiler somewhere. If 
you know we do this in .cc files already, sure, but if this is the first time, 
I'd replace with "eps" or "epsilon".


http://gerrit.cloudera.org:8080/#/c/10026/1/be/src/util/runtime-profile-counters.h
File be/src/util/runtime-profile-counters.h:

http://gerrit.cloudera.org:8080/#/c/10026/1/be/src/util/runtime-profile-counters.h@306
PS1, Line 306:     // (start_time_ns - ε), where ε is 1, 2 or 3 even though 
'start_time_ns' was
same here



--
To view, visit http://gerrit.cloudera.org:8080/10026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I72d314518087aede16e8d702c2f904b679a55f6d
Gerrit-Change-Number: 10026
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 Apr 2018 22:53:57 +0000
Gerrit-HasComments: Yes

Reply via email to