Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10026 )
Change subject: IMPALA-4631: loosen monotonic clock DCHECK ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/10026/1/be/src/runtime/fragment-instance-state.cc File be/src/runtime/fragment-instance-state.cc: http://gerrit.cloudera.org:8080/#/c/10026/1/be/src/runtime/fragment-instance-state.cc@323 PS1, Line 323: // TODO: IMPALA-4631: Occasionally we see other_time = total_time + ε where ε is 1, > I'm worried that the epsilon will kill some editor or compiler somewhere. I You're probably right that we can't have nice things :) http://gerrit.cloudera.org:8080/#/c/10026/1/be/src/util/runtime-profile-counters.h File be/src/util/runtime-profile-counters.h: http://gerrit.cloudera.org:8080/#/c/10026/1/be/src/util/runtime-profile-counters.h@306 PS1, Line 306: // (start_time_ns - ε), where ε is 1, 2 or 3 even though 'start_time_ns' was > same here Done -- To view, visit http://gerrit.cloudera.org:8080/10026 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I72d314518087aede16e8d702c2f904b679a55f6d Gerrit-Change-Number: 10026 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 11 Apr 2018 23:16:28 +0000 Gerrit-HasComments: Yes
