Fredy Wijaya has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9994 )

Change subject: IMPALA-6809: Allow bootstrap_system.sh in non ~/Impala directory
......................................................................


Patch Set 5:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/9994/3/bin/bootstrap_system.sh
File bin/bootstrap_system.sh:

http://gerrit.cloudera.org:8080/#/c/9994/3/bin/bootstrap_system.sh@24
PS3, Line 24: # variables to make Impala compile and run after this script is 
complete.
> Add a note here that it respects IMPALA_HOME
Done


http://gerrit.cloudera.org:8080/#/c/9994/3/bin/bootstrap_system.sh@102
PS3, Line 102: # If there is no Impala git repo, get one now
> Impala house style for this is:
Done


http://gerrit.cloudera.org:8080/#/c/9994/3/bin/bootstrap_system.sh@208
PS3, Line 208: then
> Define IMPALA_LZO_HOME next to where you define IMPALA_HOME and use that?
Done



--
To view, visit http://gerrit.cloudera.org:8080/9994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3241c180b5fb28f1b5f939200f72461ad6fd7d7a
Gerrit-Change-Number: 9994
Gerrit-PatchSet: 5
Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Apr 2018 00:03:32 +0000
Gerrit-HasComments: Yes

Reply via email to