Dimitris Tsirogiannis has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9777 )

Change subject: IMPALA-4025: Part 1: Add percentile_disc aggregation function
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9777/3/fe/src/main/java/org/apache/impala/analysis/SlotRef.java
File fe/src/main/java/org/apache/impala/analysis/SlotRef.java:

http://gerrit.cloudera.org:8080/#/c/9777/3/fe/src/main/java/org/apache/impala/analysis/SlotRef.java@149
PS3, Line 149: void setRawPath(List<String> rawPath) {
> It's not needed. But the existing expr substitution utilities have several
Modifying the SlotRef in place sort of violates the way we generally handle 
cases like this (e.g. when an expr needs to be replaced by another expr). I am 
in favor of refactoring the substitution logic to make it more generic and 
flexible but I'll let Alex chime on it since I haven't thought of all the 
details.



--
To view, visit http://gerrit.cloudera.org:8080/9777
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iacef7b3fcd74c4c73d88400ce27307c3baa0121e
Gerrit-Change-Number: 9777
Gerrit-PatchSet: 3
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Apr 2018 18:14:35 +0000
Gerrit-HasComments: Yes

Reply via email to