Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10031 )
Change subject: IMPALA-6713: Fix request for unneeded memory in partial sort ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/10031/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10031/1//COMMIT_MSG@9 PS1, Line 9: initialzed nit: typo http://gerrit.cloudera.org:8080/#/c/10031/1/be/src/runtime/sorter.cc File be/src/runtime/sorter.cc: http://gerrit.cloudera.org:8080/#/c/10031/1/be/src/runtime/sorter.cc@634 PS1, Line 634: + (has_var_len_slots_ && initial_run_ && sorter_->enable_spilling_); Should we also test that a regular Sort node with spilling turned off works well with the lowest memory allocation that was needed before this change? (e.g. picking any sorting query checking what the lowest memory limit it worked with spilling turned off, check that it still works with that limit) There might be an existing test for this, though. -- To view, visit http://gerrit.cloudera.org:8080/10031 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d9c0863009021340d8b684669b371a2cfb1ecad Gerrit-Change-Number: 10031 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 12 Apr 2018 18:25:13 +0000 Gerrit-HasComments: Yes
