Thomas Tauber-Marshall has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/10053


Change subject: IMPALA-6845: TestHdfsQueries causes some tests to be run twice
......................................................................

IMPALA-6845: TestHdfsQueries causes some tests to be run twice

TestHdfsQueries is a subclass of TestQueries and inherits of all its 'test_*' 
methods,
causing these tests to be run twice any time test_queries.py is run. This was 
not
intentional (it was subclassed just to inherit 'add_test_dimensions') and 
causes test runs
to take longer than necessary.

This patch removes the subclass relationship and copies the logic in 
add_test_dimensions()
from TestQueries in HdfsTestQueries, with a convenience function added to 
minimize code
duplication.

Testing:
- Ran test_queries.py under both 'core' and 'exhaustive' and checked that the 
same tests
  are run, except all now only a single time each.

Change-Id: Ida659aa7b5131a6a7469baa93a41f7581bd0659a
---
M tests/common/test_dimensions.py
M tests/query_test/test_queries.py
2 files changed, 28 insertions(+), 16 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/53/10053/1
--
To view, visit http://gerrit.cloudera.org:8080/10053
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ida659aa7b5131a6a7469baa93a41f7581bd0659a
Gerrit-Change-Number: 10053
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com>

Reply via email to