Fredy Wijaya has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10030 )

Change subject: IMPALA-6451: AuthorizationException in CTAS for Kudu tables
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10030/2/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java
File fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java:

http://gerrit.cloudera.org:8080/#/c/10030/2/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java@68
PS2, Line 68:     Preconditions.checkNotNull(tableDef);
> This flag is extremely specific and I think it adds to the reset/re-analyze
Yeah, that's a cleaner approach. I'll refactor the generated Kudu table name 
stuff as well.



--
To view, visit http://gerrit.cloudera.org:8080/10030
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac3bbe4dceb80dfefd9756bc322f8c10ceab9f49
Gerrit-Change-Number: 10030
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com>
Gerrit-Reviewer: Adam Holley <g...@holleyism.com>
Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Apr 2018 23:20:37 +0000
Gerrit-HasComments: Yes

Reply via email to