Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9966 )
Change subject: IMPALA-6813: Hedged reads metrics broken when scanning non-HDFS based table ...................................................................... Patch Set 1: > Patch Set 1: > > > Patch Set 1: > > > > I haven't added a custom cluster test for this since hedged reads are not > > deterministic, and we'd be dealing with a bunch of flakiness. > > I'm uncomfortable that we've got a flag with no testing of the code path > behind it. > > Can you force a hedged read by "kill -STOP"'ing a datanode before the query > and "kill -CONT" afterwards? Thanks for the suggestion, Phil. I will try this. -- To view, visit http://gerrit.cloudera.org:8080/9966 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I48fe80dfd9a1ed68a8f2b7038e5f42b5a3df3baa Gerrit-Change-Number: 9966 Gerrit-PatchSet: 1 Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Thu, 12 Apr 2018 23:34:08 +0000 Gerrit-HasComments: No
