Bharath Vissapragada has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9933 )

Change subject: IMPALA-2195: Improper handling of comments in queries
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/9933/3/shell/impala_shell.py
File shell/impala_shell.py:

http://gerrit.cloudera.org:8080/#/c/9933/3/shell/impala_shell.py@1279
PS3, Line 1279:     line = 
ImpalaShell.strip_trailing_comment(line.strip()).encode('utf-8')
> That was my initial attempt but then I realized it won't work because of th
Right. Currently, if you see the web UI of the running/completed queries, it 
includes the query stmt, along with the leading comments. While we are not sure 
how many users actually rely on the comment data, my thinking is that it helps 
set the context in complex workflows involving huge queries, as users typically 
include some description about what the query is about.

Not sure if others have a different opinion on this.


http://gerrit.cloudera.org:8080/#/c/9933/3/shell/impala_shell.py@1285
PS3, Line 1285:   def strip_trailing_comment(sql):
> In other places, we strip all comments from the whole line. For this partic
Yea, a totally stripped query can also help deduce the "query type". Like you 
mentioned in your previous comment, it requires changes in other places. 
Basically, we don't want to overwrite the 'line' itself, but keep a copy.



--
To view, visit http://gerrit.cloudera.org:8080/9933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ac7cb5a30e6dda73ebe761d9f0eb9ba038e14a7
Gerrit-Change-Number: 9933
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com>
Gerrit-Reviewer: David Knupp <dkn...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Apr 2018 23:45:05 +0000
Gerrit-HasComments: Yes

Reply via email to