Fredy Wijaya has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10030 )

Change subject: IMPALA-6451: AuthorizationException in CTAS for Kudu tables
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10030/4/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java
File fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java:

http://gerrit.cloudera.org:8080/#/c/10030/4/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java@259
PS4, Line 259:       if 
(kuduTableName.equals(KuduUtil.getDefaultCreateKuduTableName(
> Do we still need this logic?
I believe we still need it because this is used by "show create table" 
statement whereas the others are used by toSql() method. Removing this causes 
test_external_kudu_table_name_with_show_create to fail.



--
To view, visit http://gerrit.cloudera.org:8080/10030
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac3bbe4dceb80dfefd9756bc322f8c10ceab9f49
Gerrit-Change-Number: 10030
Gerrit-PatchSet: 5
Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com>
Gerrit-Reviewer: Adam Holley <g...@holleyism.com>
Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Apr 2018 05:13:22 +0000
Gerrit-HasComments: Yes

Reply via email to