Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10052 )

Change subject: IMPALA-6748: [DOCS] Separators when casting STRING to TIMESTAMP
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10052/1/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:

http://gerrit.cloudera.org:8080/#/c/10052/1/docs/shared/impala_common.xml@1405
PS1, Line 1405:         are accepted in the format <codeph>"yyyy-MM-dd 
HH:mm:ss.SSSSSS"</codeph>,
> I think so as the implicit casting of these forms are tested here:
Yeah the code we changed affects:
* Conversion of timestamp columns in text files
* Explicit casts, e.g. CAST('2018-01-01 1:2:3' as timestamp)
* Implicit casts to timestamp, e.g. date_part('year', '2018-1-1')



--
To view, visit http://gerrit.cloudera.org:8080/10052
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib82884d5f56c520712c4391b53b799d518d6a54f
Gerrit-Change-Number: 10052
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <arod...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <arod...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Reviewer: Vincent Tran <vtt...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Apr 2018 15:40:05 +0000
Gerrit-HasComments: Yes

Reply via email to