Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9993 )
Change subject: IMPALA-6723: [DOCS] Hints for CTAS ...................................................................... Patch Set 6: (7 comments) http://gerrit.cloudera.org:8080/#/c/9993/6/docs/topics/impala_hints.xml File docs/topics/impala_hints.xml: http://gerrit.cloudera.org:8080/#/c/9993/6/docs/topics/impala_hints.xml@258 PS6, Line 258: <codeph>/* +SHUFFLE */</codeph> Adds an exchange node which mention that this node gets added before writing the data. http://gerrit.cloudera.org:8080/#/c/9993/6/docs/topics/impala_hints.xml@260 PS6, Line 260: on the partitioning columns of the target table. This makes a This also reduces fragmentation, resulting in smaller files. Can we simplify this sentence? "makes... to be written" reads a bit odd. http://gerrit.cloudera.org:8080/#/c/9993/6/docs/topics/impala_hints.xml@268 PS6, Line 268: constructed s/written http://gerrit.cloudera.org:8080/#/c/9993/6/docs/topics/impala_hints.xml@273 PS6, Line 273: construct write http://gerrit.cloudera.org:8080/#/c/9993/6/docs/topics/impala_hints.xml@315 PS6, Line 315: each partition : column "... by the partitioning columns ..." (it's a compound key, not several consecutive sorts) http://gerrit.cloudera.org:8080/#/c/9993/6/docs/topics/impala_hints.xml@318 PS6, Line 318: or s/and http://gerrit.cloudera.org:8080/#/c/9993/6/docs/topics/impala_hints.xml@348 PS6, Line 348: partitioning I don't think Kudu has partitions, but you should confirm with Thomas. -- To view, visit http://gerrit.cloudera.org:8080/9993 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa Gerrit-Change-Number: 9993 Gerrit-PatchSet: 6 Gerrit-Owner: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Fri, 13 Apr 2018 16:40:35 +0000 Gerrit-HasComments: Yes
