Thomas Tauber-Marshall has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10053 )

Change subject: IMPALA-6845: TestHdfsQueries causes some tests to be run twice
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10053/2/tests/common/test_dimensions.py
File tests/common/test_dimensions.py:

http://gerrit.cloudera.org:8080/#/c/10053/2/tests/common/test_dimensions.py@193
PS2, Line 193:     new_value[-1].value[key] = value
> copy/paste. I think here's where you want to use key and value
Done



--
To view, visit http://gerrit.cloudera.org:8080/10053
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida659aa7b5131a6a7469baa93a41f7581bd0659a
Gerrit-Change-Number: 10053
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Apr 2018 17:22:10 +0000
Gerrit-HasComments: Yes

Reply via email to