Charles Agnello has posted comments on this change. ( http://gerrit.cloudera.org:8080/10032 )
Change subject: IMPALA-5392. Add full stack trace to jvm-threadz ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10032/1/fe/src/main/java/org/apache/impala/common/JniUtil.java File fe/src/main/java/org/apache/impala/common/JniUtil.java: http://gerrit.cloudera.org:8080/#/c/10032/1/fe/src/main/java/org/apache/impala/common/JniUtil.java@243 PS1, Line 243: private static String createSummary(ThreadInfo threadInfo) { > Instead of doing the formatting yourself, did you consider using getThreadI Using ThreadMXBean.getThreadInfo doesn't work either since you are still calling ThreadInfo.toString on what comes back from ThreadMXBean.getThreadInfo. I tried what you suggested tThreadInfo.setSummary(threadBean.getThreadInfo(id, Integer.MAX_VALUE).toString()); and the result is the same as what is currently shipping which is what I expected but I wanted to confirm. -- To view, visit http://gerrit.cloudera.org:8080/10032 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibee595358ebc2e1b48cb73356faff7a708aa6a80 Gerrit-Change-Number: 10032 Gerrit-PatchSet: 1 Gerrit-Owner: Charles Agnello <charles.w.agne...@gmail.com> Gerrit-Reviewer: Charles Agnello <charles.w.agne...@gmail.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Comment-Date: Sat, 14 Apr 2018 22:29:31 +0000 Gerrit-HasComments: Yes
