Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10058 )
Change subject: IMPALA-6847: work around high memory estimates for AC ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/10058/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10058/6//COMMIT_MSG@7 PS6, Line 7: IMPALA-6847: work around high memory estimates for AC > Could you include the new option name prominently in the commit message? Done http://gerrit.cloudera.org:8080/#/c/10058/6/common/thrift/ImpalaInternalService.thrift File common/thrift/ImpalaInternalService.thrift: http://gerrit.cloudera.org:8080/#/c/10058/6/common/thrift/ImpalaInternalService.thrift@284 PS6, Line 284: // this value, use this as the memory limit for the purposes of admission. 0 or -1 > Could you add a comment about what happens if the estimate is below this va Copied over the text from the other place (this text was stale). -- To view, visit http://gerrit.cloudera.org:8080/10058 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia5fc32a507ad0f00f564dfe4f954a829ac55d14e Gerrit-Change-Number: 10058 Gerrit-PatchSet: 6 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 16 Apr 2018 18:52:23 +0000 Gerrit-HasComments: Yes
