Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10085 )
Change subject: IMPALA-6749: Implement ALTER DATABASE SET DBPROPERTIES ...................................................................... Patch Set 4: > Patch Set 4: > > Why are we exposing this? I'm worried that we're exposing (more) untyped > key-value stores that will get abused. We are already displaying the DB properties with DESCRIBE DATABASE EXTENDED/FORMATTED set externally, e.g. in Hive: https://github.com/apache/impala/blob/master/fe/src/main/java/org/apache/impala/service/DescribeResultFactory.java#L154-L167 Hive also supports ALTER DATABASE SET DBPROPERTIES: https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL#LanguageManualDDL-Create/Drop/Alter/UseDatabase I thought it would be nice to have that feature in Impala. -- To view, visit http://gerrit.cloudera.org:8080/10085 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08bc4a9c6fa95dd135274fa1081bf24ebe14c99a Gerrit-Change-Number: 10085 Gerrit-PatchSet: 4 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Comment-Date: Tue, 17 Apr 2018 18:26:10 +0000 Gerrit-HasComments: No
