Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10058 )
Change subject: IMPALA-6847: work around high memory estimates for AC ...................................................................... Patch Set 12: (4 comments) http://gerrit.cloudera.org:8080/#/c/10058/12//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10058/12//COMMIT_MSG@9 PS12, Line 9: MAX_MEM_LIMIT_FOR_ADMISSION update http://gerrit.cloudera.org:8080/#/c/10058/12//COMMIT_MSG@14 PS12, Line 14: MAX_MEM_LIMIT_FOR_ADMISSION same http://gerrit.cloudera.org:8080/#/c/10058/12/common/thrift/ImpalaService.thrift File common/thrift/ImpalaService.thrift: http://gerrit.cloudera.org:8080/#/c/10058/12/common/thrift/ImpalaService.thrift@294 PS12, Line 294: // See comment in ImpalaInternalService.thrift I like the idea of de-duping the comments, but perhaps it should go the other direction, given that this is the public impala service interface, and ImpalaInternalService is the internal impalad to impalad interface. http://gerrit.cloudera.org:8080/#/c/10058/12/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/10058/12/fe/src/main/java/org/apache/impala/service/Frontend.java@1065 PS12, Line 1065: // shown in the plan. given that, will it be hard to diagnose admission decisions? though I guess we now print query options in the profile, so probably we're okay. -- To view, visit http://gerrit.cloudera.org:8080/10058 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia5fc32a507ad0f00f564dfe4f954a829ac55d14e Gerrit-Change-Number: 10058 Gerrit-PatchSet: 12 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 17 Apr 2018 19:20:08 +0000 Gerrit-HasComments: Yes
