Hello Lars Volker, Philip Zeyliger,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/10093

to review the following change.


Change subject: IMPALA-6863: Make pip_download.py honor redirects.
......................................................................

IMPALA-6863: Make pip_download.py honor redirects.

As part of our continuing woes with PyPi infrastructure, we've now seen
redirects. Following redirects seems like the right thing to do, so I've
changed the downloader code to follow them.

I checked that this is available in Python 2.6.

The build failure signature looks like:

   Downloading AllPairs-2.0.1.tar.gz from 
https://pypi.python.org/packages/04/44/cb85d029b33ddfa7b5a27ae523434c2230f11a89d1f0c73203e9007a6eb0/AllPairs-2.0.1.tar.gz
   ('http error', 302, 'Found', <httplib.HTTPMessage instance at 
0x7fbf7819b050>)
   Download failed after several attempts.
   Warning: Unable to download Python requirements.
   Warning: bootstrap_virtualenv or other Python-based tooling may fail.

Change-Id: Ic7551cec43a2d378df7e3cc7d521ace338b56ba2
Reviewed-on: http://gerrit.cloudera.org:8080/10083
Reviewed-by: Philip Zeyliger <[email protected]>
Tested-by: Philip Zeyliger <[email protected]>
Reviewed-by: Lars Volker <[email protected]>
(cherry picked from commit eaf66172df113dbf10cdb0a08a2bc51e4077ca38)
---
M infra/python/deps/pip_download.py
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/10093/1
--
To view, visit http://gerrit.cloudera.org:8080/10093
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic7551cec43a2d378df7e3cc7d521ace338b56ba2
Gerrit-Change-Number: 10093
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Lars Volker <[email protected]>
Gerrit-Reviewer: Philip Zeyliger <[email protected]>

Reply via email to