Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10113 )
Change subject: IMPALA-6887: Typo in authz-policy.ini.template ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/10113/1/fe/src/test/resources/authz-policy.ini.template File fe/src/test/resources/authz-policy.ini.template: http://gerrit.cloudera.org:8080/#/c/10113/1/fe/src/test/resources/authz-policy.ini.template@71 PS1, Line 71: alter_functional_text_lzo = server=server1->db=functional_text_lzo->action=alter > Does it mean nothing uses this role? If so, can that be removed? Yeah apparently it's not used, but it should be used to have a better coverage. I'm currently working on the rewrite of authorization tests. I can slap some extra test cases in the existing authorization test to have better coverage for now. -- To view, visit http://gerrit.cloudera.org:8080/10113 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6aea8d71dda39838e9e70160018ce2c5fc73df21 Gerrit-Change-Number: 10113 Gerrit-PatchSet: 2 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Adam Holley <g...@holleyism.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Comment-Date: Thu, 19 Apr 2018 02:42:46 +0000 Gerrit-HasComments: Yes
