Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10116 )
Change subject: IMPALA-6131: Track time of last statistics update in metadata ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/10116/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10116/2//COMMIT_MSG@28 PS2, Line 28: ablo > typo, and missing 'to' Done http://gerrit.cloudera.org:8080/#/c/10116/2//COMMIT_MSG@30 PS2, Line 30: > + 'be'? Done http://gerrit.cloudera.org:8080/#/c/10116/2/fe/src/main/java/org/apache/impala/catalog/KuduTable.java File fe/src/main/java/org/apache/impala/catalog/KuduTable.java: http://gerrit.cloudera.org:8080/#/c/10116/2/fe/src/main/java/org/apache/impala/catalog/KuduTable.java@239 PS2, Line 239: msTable_.deepCopy(); > Why do we deep copy it now? Do be honest, I am not sure about this part - without deep copy, DESCRIBE TABLE did not work as intended for Kudu tables, transient_lastDdlTime was missing. I consider the Kudu part to be "work in progress". Note that CatalogOpExecutor always deep copies the tables before calling applyAlterTable(), which calls HmsClient's alter_table(), so this seams to be the normal way to do it in Impala. -- To view, visit http://gerrit.cloudera.org:8080/10116 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I59a671ac29d352bd92ce40d5cb6662bb23f146b5 Gerrit-Change-Number: 10116 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 19 Apr 2018 15:59:54 +0000 Gerrit-HasComments: Yes
