Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10119 )
Change subject: IMPALA-6821: Push down limits into Kudu ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/10119/2/tests/query_test/test_queries.py File tests/query_test/test_queries.py: http://gerrit.cloudera.org:8080/#/c/10119/2/tests/query_test/test_queries.py@60 PS2, Line 60: def test_limit_nondeterminstic(self, vector): I'd prefer to revert this move and add a new test specifically for Kudu in kudu_test.py. I assume Kudu has tested these scenarios, but it would be good to confirm on our side that the limit works correctly in the following situations: * No predicates * PK Kudu predicate only * non-PK Kudu predicate only * Kudu predicates and Impala predicates * Any other interesting cases with predicates you can think of? Anything special about partitioning columns maybe? -- To view, visit http://gerrit.cloudera.org:8080/10119 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe35e70065d8706b575e24fe20902cd405b49941 Gerrit-Change-Number: 10119 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Fri, 20 Apr 2018 22:08:17 +0000 Gerrit-HasComments: Yes
