Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10155 )
Change subject: IMPALA-6905: support regexes with more verifiers ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/10155/1/testdata/workloads/functional-query/queries/QueryTest/stats-extrapolation.test File testdata/workloads/functional-query/queries/QueryTest/stats-extrapolation.test: http://gerrit.cloudera.org:8080/#/c/10155/1/testdata/workloads/functional-query/queries/QueryTest/stats-extrapolation.test@17 PS1, Line 17: row_regex:.* extrapolated-rows=unavailable.* > Did you intend to remove the "mem-estimate" line? Yes, I didn't see the point in updating mem-estimate here every time we change the estimates. It's a regex because in future we're going to add more information to the line that this test doesn't need to verify. See http://gerrit.cloudera.org:8080/9757. http://gerrit.cloudera.org:8080/#/c/10155/1/testdata/workloads/functional-query/queries/QueryTest/stats-extrapolation.test@70 PS1, Line 70: row_regex:.* extrapolated-rows=3650.* > why this change? See above. This is prefetching some of the work in http://gerrit.cloudera.org:8080/9757 so that it doesn't need to update tests like this that aren't directly relevant. http://gerrit.cloudera.org:8080/#/c/10155/1/testdata/workloads/functional-query/queries/QueryTest/stats-extrapolation.test@121 PS1, Line 121: row_regex:.* extrapolated-rows=7300.* > I'm not following why we need row_regex here See above. -- To view, visit http://gerrit.cloudera.org:8080/10155 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7a28d421c8e7cd84b14d07fcb71b76449156409 Gerrit-Change-Number: 10155 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 23 Apr 2018 22:50:06 +0000 Gerrit-HasComments: Yes
