Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9943 )
Change subject: IMPALA-5706: Parallelise read I/O in sorter ...................................................................... Patch Set 6: (2 comments) Thanks Csaba for taking a look at this review! Carry +1 http://gerrit.cloudera.org:8080/#/c/9943/3/be/src/runtime/sorter.cc File be/src/runtime/sorter.cc: http://gerrit.cloudera.org:8080/#/c/9943/3/be/src/runtime/sorter.cc@1039 PS3, Line 1039: > You don't have to go into details here, but I still think that the current Done http://gerrit.cloudera.org:8080/#/c/9943/5/tests/query_test/test_sort.py File tests/query_test/test_sort.py: http://gerrit.cloudera.org:8080/#/c/9943/5/tests/query_test/test_sort.py@137 PS5, Line 137: sort1_profile = self.get_sort_node_profile(1, result.runtime_profile) : assert(sort1_profile.find("TotalMergesPerformed: 7") > 0) : : # The second sort extends its memory allocation with the pages the first sort releases : # when it finishes. As a result it has more memory for in > Can you add a short explanation about the cause of the difference between t Good point. Done. -- To view, visit http://gerrit.cloudera.org:8080/9943 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I74857c1694802e81f1cfc765d2b4e8bc644387f9 Gerrit-Change-Number: 9943 Gerrit-PatchSet: 6 Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 24 Apr 2018 10:27:42 +0000 Gerrit-HasComments: Yes
