Hello Philip Zeyliger,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10177
to look at the new patch set (#3).
Change subject: IMPALA-6740: Fix flaky test_cancellation
......................................................................
IMPALA-6740: Fix flaky test_cancellation
test_shall_commandline:test_cancellation starts an Impala shell
process, runs a query, sleeps briefly, and then cancels the query by
sending a SIGINT to the process. This has been occasionally failing
with either the error 'KeyboardInterrupt' or with the query succeeding
instead of being cancelled.
The problem occurs if the process hasn't fully started up before the
SIGINT is sent - in particular, if ImpalaShell:__init__ hasn't
installed the signal handler, which happens sometimes depending on
concurrent load on the machine. Depending on the exact timing, this
may cause a 'KeyboardInterrupt' that isn't handled, or the signal
may be ignored and the query allowed to run to completion.
The solution is to increase the time spent sleeping.
Testing:
- I can reliably repro the problem locally by reducing the sleep time.
Change-Id: I5d13de6207807e4ba2e2e406a29d670f01d6c3a0
---
M tests/shell/test_shell_commandline.py
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/10177/3
--
To view, visit http://gerrit.cloudera.org:8080/10177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5d13de6207807e4ba2e2e406a29d670f01d6c3a0
Gerrit-Change-Number: 10177
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Tauber-Marshall <[email protected]>
Gerrit-Reviewer: Philip Zeyliger <[email protected]>
