Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/20752 )
Change subject: IMPALA-12001: Informative error message for complex types with DISTINCT ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/20752/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20752/2//COMMIT_MSG@18 PS2, Line 18: nit: comma http://gerrit.cloudera.org:8080/#/c/20752/2/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java File fe/src/main/java/org/apache/impala/analysis/SelectStmt.java: http://gerrit.cloudera.org:8080/#/c/20752/2/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@565 PS2, Line 565: if (selectList_.isDistinct() && expr.getType().isComplexType()) { Just a question: there are numerous cases when we use format strings as error messages instead of simple concatenation. Is there a guideline for determining when to use format strings as opposed to concatenation? http://gerrit.cloudera.org:8080/#/c/20752/2/testdata/workloads/functional-query/queries/QueryTest/nested-array-in-select-list.test File testdata/workloads/functional-query/queries/QueryTest/nested-array-in-select-list.test: http://gerrit.cloudera.org:8080/#/c/20752/2/testdata/workloads/functional-query/queries/QueryTest/nested-array-in-select-list.test@456 PS2, Line 456: = nit: one superfluous '=' http://gerrit.cloudera.org:8080/#/c/20752/2/testdata/workloads/functional-query/queries/QueryTest/nested-map-in-select-list.test File testdata/workloads/functional-query/queries/QueryTest/nested-map-in-select-list.test: http://gerrit.cloudera.org:8080/#/c/20752/2/testdata/workloads/functional-query/queries/QueryTest/nested-map-in-select-list.test@437 PS2, Line 437: ===== nit: one superfluous '=' -- To view, visit http://gerrit.cloudera.org:8080/20752 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe2642d1683a10fd05a95e2ad8470d16f0d5242c Gerrit-Change-Number: 20752 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Wed, 06 Dec 2023 15:54:50 +0000 Gerrit-HasComments: Yes
