Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/20485 )
Change subject: IMPALA-10949: Improve batching logic of partition events ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/20485/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/20485/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1282 PS1, Line 1282: t > If we already check getLastSyncedEventId(), wouldn't it be simpler to drop Exactly for that reason, I'm checking the lastSyncEventId() in the canBeBatched(). CanBeBatched() determines if the event can be batched, if the lastSyncEventId() is greater than the eventId then we can ignore the event without batching. http://gerrit.cloudera.org:8080/#/c/20485/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1284 PS1, Line 1284: msTbl_ = Preconditions.checkNotNull(insertMessage.getTableObj()); : insertPartition_ = insertMessage.getPtnObj(); : } catch (Exception e) { : throw new MetastoreNotificationException(debugString("Unable to " : + "parse insert message"), e); : } : } : : @Ov > This seems to be the same as for alter table events - a function like bool Ack -- To view, visit http://gerrit.cloudera.org:8080/20485 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4e79510739347cbe669719a9e4cb9cabd5daa7d3 Gerrit-Change-Number: 20485 Gerrit-PatchSet: 2 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Thu, 07 Dec 2023 03:26:17 +0000 Gerrit-HasComments: Yes
