Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/20759 )
Change subject: IMPALA-12205: Add support to STRUCT type Iceberg Metadata table columns ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/20759/1/be/src/exec/iceberg-metadata/iceberg-row-reader.h File be/src/exec/iceberg-metadata/iceberg-row-reader.h: http://gerrit.cloudera.org:8080/#/c/20759/1/be/src/exec/iceberg-metadata/iceberg-row-reader.h@45 PS1, Line 45: Status MaterializeTuple(JNIEnv* env, jobject struct_like_row, const TupleDescriptor* tuple_desc, > line too long (98 > 90) Done http://gerrit.cloudera.org:8080/#/c/20759/1/be/src/exec/iceberg-metadata/iceberg-row-reader.cc File be/src/exec/iceberg-metadata/iceberg-row-reader.cc: http://gerrit.cloudera.org:8080/#/c/20759/1/be/src/exec/iceberg-metadata/iceberg-row-reader.cc@79 PS1, Line 79: accessed_value = env->CallObjectMethod(accessor, iceberg_accessor_get_, struct_like_row); > line too long (95 > 90) Done http://gerrit.cloudera.org:8080/#/c/20759/1/be/src/exec/iceberg-metadata/iceberg-row-reader.cc@104 PS1, Line 104: RETURN_IF_ERROR(WriteStructSlot(env, struct_like_row, slot_desc, tuple, tuple_data_pool)); > line too long (98 > 90) Done http://gerrit.cloudera.org:8080/#/c/20759/1/be/src/exec/iceberg-metadata/iceberg-row-reader.cc@172 PS1, Line 172: Status IcebergRowReader::WriteStructSlot(JNIEnv* env, jobject struct_like_row, SlotDescriptor* slot_desc, Tuple* tuple, > line too long (119 > 90) Done -- To view, visit http://gerrit.cloudera.org:8080/20759 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I953ad7253b270f2855bfcaee4ad023d1c4469273 Gerrit-Change-Number: 20759 Gerrit-PatchSet: 1 Gerrit-Owner: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 07 Dec 2023 10:07:24 +0000 Gerrit-HasComments: Yes
