Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/20508 )
Change subject: IMPALA-12398: Fix Ranger role not exists when altering db/table/view owner to a role ...................................................................... Patch Set 7: (1 comment) Thanks for working on the patch Ji! I do not have any additional suggestion. We could bump the code-review to +2 if Quanlong does not have any comment either. http://gerrit.cloudera.org:8080/#/c/20508/7/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java File fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java: http://gerrit.cloudera.org:8080/#/c/20508/7/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java@2548 PS7, Line 2548: ALTER VIEW SET OWNER ROLE > Could we also add a test case for the ALTER DATABASE SET OWNER ROLE stateme According to an offline discussion with Ji, a test case for the ALTER DATABASE SET OWNER ROLE statement is already there at https://github.com/apache/impala/blob/master/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java#L2613-L2619. Thus there is no need to add another test case. try { parseAndAnalyze("alter database functional set owner role foo", authzCtx_, frontend_); } catch (AnalysisException e) { exceptionThrown = true; assertEquals("Role 'foo' does not exist.", e.getLocalizedMessage()); } -- To view, visit http://gerrit.cloudera.org:8080/20508 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2b029bdb90111dbd0eab5189360cc81090225cda Gerrit-Change-Number: 20508 Gerrit-PatchSet: 7 Gerrit-Owner: ji chen <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: ji chen <[email protected]> Gerrit-Comment-Date: Mon, 11 Dec 2023 01:05:15 +0000 Gerrit-HasComments: Yes
