Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20490 )

Change subject: IMPALA-12448: Avoid getting stuck when refreshing a 
non-existent partition
......................................................................


Patch Set 22:

(2 comments)

> Patch Set 22:
>
> > Patch Set 20:
> >
> > > Patch Set 20: Verified-1
> > >
> > > Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9982/
> >
> > custom_cluster.test_incremental_metadata_updates.TestIncrementalMetadataUpdate.test_long_statestore_update_frequency
> >  keeps failing after this patch.
> > https://jenkins.impala.io/job/ubuntu-20.04-from-scratch/1037
> >
> > custom_cluster/test_incremental_metadata_updates.py:58: in 
> > test_long_statestore_update_frequency
> >     .format(unique_database, i))
> > common/impala_connection.py:214: in execute
> >     return self.__beeswax_client.execute(sql_stmt, user=user)
> > beeswax/impala_beeswax.py:191: in execute
> >     handle = self.__execute_query(query_string.strip(), user=user)
> > beeswax/impala_beeswax.py:367: in __execute_query
> >     handle = self.execute_query_async(query_string, user=user)
> > beeswax/impala_beeswax.py:361: in execute_query_async
> >     handle = self.__do_rpc(lambda: self.imp_service.query(query,))
> > beeswax/impala_beeswax.py:524: in __do_rpc
> >     raise ImpalaBeeswaxException(self.__build_error_message(b), b)
> > E   ImpalaBeeswaxException: ImpalaBeeswaxException:
> > E    INNER EXCEPTION: <class 'beeswaxd.ttypes.BeeswaxException'>
> > E    MESSAGE: AnalysisException: Database does not exist: 
> > test_long_statestore_update_frequency_3942be87
>
> I have committed the latest code. Thanks Quanlong!

Haven't digged into the test failure. Could you share why the test failed?

http://gerrit.cloudera.org:8080/#/c/20490/22/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:

http://gerrit.cloudera.org:8080/#/c/20490/22/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@6562
PS22, Line 6562: =0
nit: add a space after '='


http://gerrit.cloudera.org:8080/#/c/20490/22/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@6705
PS22, Line 6705: preTblCatalogVersion
Catalog topic version is different than the catalog object version. It's the 
version of the statestore topic updates. Why can we mix using them together?



--
To view, visit http://gerrit.cloudera.org:8080/20490
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iace7cdadda300b03896f92415822266354421887
Gerrit-Change-Number: 20490
Gerrit-PatchSet: 22
Gerrit-Owner: ttttttz <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: ttttttz <[email protected]>
Gerrit-Comment-Date: Mon, 11 Dec 2023 08:30:48 +0000
Gerrit-HasComments: Yes

Reply via email to