Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20697 )

Change subject: IMPALA-11805: Fix LLVM memory manager bytes allocated
......................................................................


Patch Set 13: Verified+1

> Patch Set 13:
>
> > Patch Set 13: Code-Review+1
> >
> > LGTM!!
> > Considering the rise in bytes_allocated after the change, have you run 
> > exhaustive tests to ensure the memory tracker can handle the increased 
> > demand?
>
> Good idea, I'll do that.

Exhaustive run ran into IMPALA-12500, but otherwise passed.


--
To view, visit http://gerrit.cloudera.org:8080/20697
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a0193a1694db0718d75651dc2b2f9f92c0d6064
Gerrit-Change-Number: 20697
Gerrit-PatchSet: 13
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Yida Wu <[email protected]>
Gerrit-Comment-Date: Mon, 11 Dec 2023 18:44:48 +0000
Gerrit-HasComments: No

Reply via email to