[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/20506 )
Change subject: IMPALA-12465: Unicode column name support ...................................................................... Patch Set 18: (3 comments) > Uploaded patch set 18. http://gerrit.cloudera.org:8080/#/c/20506/14/fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java File fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java: http://gerrit.cloudera.org:8080/#/c/20506/14/fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java@826 PS14, Line 826: : /* > nit: Use two stars in the first line of method comment, i.e. /** Done http://gerrit.cloudera.org:8080/#/c/20506/14/fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java@830 PS14, Line 830: pu > nit: use 2 spaces indention Done http://gerrit.cloudera.org:8080/#/c/20506/14/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java: http://gerrit.cloudera.org:8080/#/c/20506/14/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@465 PS14, Line 465: > Instead of deleting these, we should change them into AnalyzesOk(). It leads to further errors, as other tests are not expecting those columns eg. `???`. That's why I didn't write them into AnalyzeOk(). -- To view, visit http://gerrit.cloudera.org:8080/20506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1ad9d63ac1b9631a0f4a433798bd5109aa2ed718 Gerrit-Change-Number: 20506 Gerrit-PatchSet: 18 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 12 Dec 2023 11:38:03 +0000 Gerrit-HasComments: Yes
