Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20769 )
Change subject: IMPALA-12589: Ignore FbFileDesc.absolutePath() if it is null/empty ...................................................................... Patch Set 5: Code-Review+1 (2 comments) Had minor comments, but LGTM! http://gerrit.cloudera.org:8080/#/c/20769/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20769/5//COMMIT_MSG@13 PS5, Line 13: Could you please elaborate on how and why this happens? http://gerrit.cloudera.org:8080/#/c/20769/5/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: http://gerrit.cloudera.org:8080/#/c/20769/5/tests/query_test/test_scanners.py@1993 PS5, Line 1993: select_stmt = "select count(*) from {db}.{tbl}".format(**params) Maybe we could check the result of the count(*) at least. -- To view, visit http://gerrit.cloudera.org:8080/20769 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I15d811430871cd1319d9560901318c1c3b89403c Gerrit-Change-Number: 20769 Gerrit-PatchSet: 5 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 12 Dec 2023 19:07:52 +0000 Gerrit-HasComments: Yes
