Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20773 )
Change subject: IMPALA-12229: Support soft-delete Kudu table ...................................................................... Patch Set 2: (2 comments) Thanks for your contribution. It looks good to me. http://gerrit.cloudera.org:8080/#/c/20773/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20773/2//COMMIT_MSG@11 PS2, Line 11: prevent users deleting nit: prevent users from deleting http://gerrit.cloudera.org:8080/#/c/20773/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/20773/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2683 PS2, Line 2683: dropTablesFromKudu(db, kudu_table_reserve_seconds) What's behavior of Kudu engine for soft table deletion when the database is dropped? Can we recover the tables after database is deleted? -- To view, visit http://gerrit.cloudera.org:8080/20773 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3020567bb6cfe4dd48ef17906f8de674f37217e7 Gerrit-Change-Number: 20773 Gerrit-PatchSet: 2 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 12 Dec 2023 19:11:49 +0000 Gerrit-HasComments: Yes
