Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20491 )
Change subject: IMPALA-12443: Add catalog timeline for all ddl profiles ...................................................................... Patch Set 9: (2 comments) Thanks for working on this, it will be extremely useful. Looked at the Iceberg-related parts. http://gerrit.cloudera.org:8080/#/c/20491/9/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java File fe/src/main/java/org/apache/impala/catalog/IcebergTable.java: http://gerrit.cloudera.org:8080/#/c/20491/9/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@405 PS9, Line 405: GroupedContentFiles icebergFiles = IcebergUtil.getIcebergFiles(this, : new ArrayList<>(), /*timeTravelSpec=*/null); I think it'd be worth to mark an event after this since the planFiles() call in getIcebergFiles() can take a significant time. http://gerrit.cloudera.org:8080/#/c/20491/9/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/20491/9/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@7109 PS9, Line 7109: catalogTimeline.markEvent("Executed Iceberg operation"); Can we include update.getIceberg_operation() in the event? -- To view, visit http://gerrit.cloudera.org:8080/20491 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifbceefaeb24c66eb1a064c449d6f56077ea347c5 Gerrit-Change-Number: 20491 Gerrit-PatchSet: 9 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 12 Dec 2023 20:26:09 +0000 Gerrit-HasComments: Yes
