Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20775 )
Change subject: IMPALA-12617: Fix DCHECK failure for Statestore ...................................................................... IMPALA-12617: Fix DCHECK failure for Statestore Statestore uses thread pools to periodically send catalog topic update and cluster membership. It adds sending tasks to the queues of thread pools when receiving registration requests from subscribers so the thread pools have to be ready before the Thrift server of Statestore is started to accept registration request. Current code call ThreadPool::Init() after the Thrift server is started. This could cause Statestore to hit DCHECK failure when calling ThreadPool::Offer(). It's more likely to happen when Statestore HA is enabled since Statestore takes more time for initialization. This patch changes the order to call ThreadPool::Init() before starting Thrift server of the Statestore server. Testing: - Repeatedly ran custom_cluster/test_statestored_ha.py on local machine and Jenkins over night without failure. - Passed core tests. Change-Id: I91423f3de2d64cb617a06ea7adbe5ee2937bde66 Reviewed-on: http://gerrit.cloudera.org:8080/20775 Reviewed-by: Riza Suminto <[email protected]> Reviewed-by: Michael Smith <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/statestore/statestore.cc 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Riza Suminto: Looks good to me, but someone else must approve Michael Smith: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/20775 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I91423f3de2d64cb617a06ea7adbe5ee2937bde66 Gerrit-Change-Number: 20775 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
