Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10182 )
Change subject: add impala-flake8 ...................................................................... add impala-flake8 Add flake8 and dependencies to impala-python. The versions are compatible with Python 2.6.6. Add the impala-flake8 entry point, similar to impala-python. Add setup.cfg which defines flake8 special rules and exemptions. They are added to support 2-space indents and a max line length of 90. Contributors writing Python can use impala-flake8 to look for formatting mistakes. The two most common uses would be: impala-flake8 myfile.py or git diff HEAD^ myfile.py | impala-flake8 --diff In the second usage, flake8 will only examine lines changed. This allows a contributor to fix their own code and not be penalized by flake8 violations that may already be present (though they are encouraged to fix them if they can!) Change-Id: Ib4ce9eca6f8b55eaec1c96e7db1ff630ac016be0 Reviewed-on: http://gerrit.cloudera.org:8080/10182 Reviewed-by: Michael Brown <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- A bin/impala-flake8 M infra/python/deps/requirements.txt A setup.cfg 3 files changed, 47 insertions(+), 0 deletions(-) Approvals: Michael Brown: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/10182 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ib4ce9eca6f8b55eaec1c96e7db1ff630ac016be0 Gerrit-Change-Number: 10182 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Brown <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]>
