Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/20719 )
Change subject: IMPALA-12433: Share buffers among channels in KrpcDataStreamSender ...................................................................... Patch Set 10: (11 comments) http://gerrit.cloudera.org:8080/#/c/20719/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20719/8//COMMIT_MSG@12 PS8, Line 12: This patch switches to use a single buffer per channel. This is > Please also discuss the partitioned case, as that seems to be handled diffe You mean in that unpartitioned case? The partitioned case uses 1 buffer per channel. http://gerrit.cloudera.org:8080/#/c/20719/8//COMMIT_MSG@18 PS8, Line 18: calculation has several issues (see IMPALA-12594). > Is this supposed to point to IMPALA-12594? oops, thanks http://gerrit.cloudera.org:8080/#/c/20719/8/be/src/benchmarks/row-batch-serialize-benchmark.cc File be/src/benchmarks/row-batch-serialize-benchmark.cc: http://gerrit.cloudera.org:8080/#/c/20719/8/be/src/benchmarks/row-batch-serialize-benchmark.cc@345 PS8, Line 345: > What cleanup is still needed? no, this remains from an older state of the patch http://gerrit.cloudera.org:8080/#/c/20719/8/be/src/catalog/catalog-util.cc File be/src/catalog/catalog-util.cc: http://gerrit.cloudera.org:8080/#/c/20719/8/be/src/catalog/catalog-util.cc@358 PS8, Line 358: return Status::OK(); > Please note why this was added in the commit message (i.e. what was missed This was needed only in a previous state of the patch, which made LZ4 compressor stateful. Decided to separate that change as it is orthogonal, so this is no longer needed. http://gerrit.cloudera.org:8080/#/c/20719/8/be/src/runtime/krpc-data-stream-sender.h File be/src/runtime/krpc-data-stream-sender.h: http://gerrit.cloudera.org:8080/#/c/20719/8/be/src/runtime/krpc-data-stream-sender.h@172 PS8, Line 172: Status SerializeBatch( > Please update the function comment to describe how 'compress' should be use Done http://gerrit.cloudera.org:8080/#/c/20719/8/be/src/runtime/krpc-data-stream-sender.cc File be/src/runtime/krpc-data-stream-sender.cc: http://gerrit.cloudera.org:8080/#/c/20719/8/be/src/runtime/krpc-data-stream-sender.cc@123 PS8, Line 123: // backing the in-flight RPC or kept as reserve if there is no ongoing RPC. The actual > typo: in-flight Done http://gerrit.cloudera.org:8080/#/c/20719/8/be/src/runtime/krpc-data-stream-sender.cc@128 PS8, Line 128: // unpartitioned case the shared outbound_batch_ holds the data for the the in-flight RPC. > typo: in-flight Done http://gerrit.cloudera.org:8080/#/c/20719/8/be/src/runtime/krpc-data-stream-sender.cc@185 PS8, Line 185: // If 'swap_batch' is true, 'outbound_batch' is swapped with the Channel's > Please update the comment to describe when swap_batch should be true/false. Done http://gerrit.cloudera.org:8080/#/c/20719/8/be/src/runtime/krpc-data-stream-sender.cc@244 PS8, Line 244: // Owns an outbound row batch that can be referenced by the in-flight RPC. Contains > Does this TODO still make sense? yes, I think that it could make things lot faster in some scenarios I was considering adding simple queuing in this patch, but ideally it would be added together with / after implementing reservation support for KrpcDataStreamSender, which is a more complex task http://gerrit.cloudera.org:8080/#/c/20719/8/be/src/runtime/krpc-data-stream-sender.cc@601 PS8, Line 601: rpc_in_flight_ = true; > Is there a DCHECK we could add here? Done http://gerrit.cloudera.org:8080/#/c/20719/8/be/src/runtime/row-batch.h File be/src/runtime/row-batch.h: http://gerrit.cloudera.org:8080/#/c/20719/8/be/src/runtime/row-batch.h@414 PS8, Line 414: Status Serialize(OutboundRowBatch* output_batch, bool full_dedup, > line has trailing whitespace Done -- To view, visit http://gerrit.cloudera.org:8080/20719 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64854a350a9dae8bf3af11c871882ea4750e60b3 Gerrit-Change-Number: 20719 Gerrit-PatchSet: 10 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Thu, 14 Dec 2023 12:22:15 +0000 Gerrit-HasComments: Yes
