Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20794 )
Change subject: IMPALA-12630: Deflake TestOrcStats.test_orc_stats ...................................................................... Patch Set 1: > Patch Set 1: > > I am not sure that this is enough to deflake all ORC tests. > This error probably comes from something similar in complextypestbl: > https://jenkins.impala.io/job/ubuntu-20.04-from-scratch/1153/testReport/junit/query_test.test_nested_types/TestNestedTypes/test_scanner_array_materialization_orc_schema_resolution__0___mt_dop__0___protocol__beeswax___exec_option____test_replan___1___batch_size___0___num_nodes___0___disable_codegen_rows_threshold___0___disable_codegen___False___abort_on_error___1___exec_single_node_rows_threshold___0____table_format__orc_def_block_/ > > I think that it would be better to revert for now, and as a long term > solution find the right Hive configs to force files in a (more) deterministic > way. Fair point. I did not see that it break so much more tests. I'll go with the revert. -- To view, visit http://gerrit.cloudera.org:8080/20794 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibb7bb25b44878df3e037e750a985656ed6857a7d Gerrit-Change-Number: 20794 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 14 Dec 2023 20:45:21 +0000 Gerrit-HasComments: No
